Handle SIGINT to abort hanging queries in ValidateBuilderExists #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/enhancement
Signed-off-by: sagnik3788 <[email protected]>
Signed-off-by: sagnik3788 <[email protected]>
Signed-off-by: sagnik3788 <[email protected]>
Signed-off-by: sagnik3788 <[email protected]>
|
@natalieparellano, any idea why |
|
@sagnik3788 I'm seeing |
|
Linux machine @natalieparellano |
Comment on lines
+76
to
+77
| sigChan := make(chan os.Signal, 1) | ||
| signal.Notify(sigChan, syscall.SIGINT, syscall.SIGTERM) |
There was a problem hiding this comment.
We'll probably want a separate implementation of this for linux/darwin and windows. This can be accomplished with separate files, such as signal_unix.go and signal_windows.go, and build tags as shown here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
ValidateBuilderExistsfunction to handle SIGINT signals. This update ensures that interrupted hanging queries gracefully abort, returning an "operation aborted" errorBefore
Crtl+C does not abort hanging query
After
operation aborted
Resolves #1242